Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ASM dependency #2279

Merged
merged 1 commit into from Apr 29, 2021
Merged

Remove ASM dependency #2279

merged 1 commit into from Apr 29, 2021

Conversation

iemejia
Copy link
Contributor

@iemejia iemejia commented Apr 28, 2021

Mockito depends on byte-buddy to make most of its bytecode fiddling but ASM is still needed for the tests. We can remove this dependency by relying on the already shaded version included on ASM, that we we won't get unaligned between both dependencies and we will remove the need for the explicit ASM library.

R: @raphw

Checklist

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

@TimvdLippe TimvdLippe requested a review from raphw April 28, 2021 16:39
@raphw
Copy link
Member

raphw commented Apr 28, 2021

I'd go as far as to say we should rather eliminate ASM altogether and use Byte Buddy's API to create the interface. That's a one-liner more or less:

new ByteBuddy()
            .makeInterface(qualifiedName)
            .make()

This avoids handling the technicalities.

@codecov-commenter
Copy link

Codecov Report

Merging #2279 (b161bcb) into release/3.x (641d161) will not change coverage.
The diff coverage is n/a.

❗ Current head b161bcb differs from pull request most recent head e66366e. Consider uploading reports for the commit e66366e to get more accurate results
Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #2279   +/-   ##
==============================================
  Coverage          84.89%   84.89%           
  Complexity          2736     2736           
==============================================
  Files                326      326           
  Lines               8342     8342           
  Branches             997      997           
==============================================
  Hits                7082     7082           
  Misses               986      986           
  Partials             274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 641d161...e66366e. Read the comment docs.

@iemejia
Copy link
Contributor Author

iemejia commented Apr 29, 2021

Oh I only took a look at the imports :) thanks for the suggestion @raphw, PTAL again

Copy link
Member

@raphw raphw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants