Swallowed illegal access exceptions make it harder to debug modularity-related issues

[A248]

Issue Summary

In FieldReader and ReflectionMemberAccessor, if an IllegalAccessException is thrown, it will be suppressed.

At the very least, Mockito should include the original exception. When testing a modular application, it is common to have packages encapsulated by default.

Stacktrace

In FieldReader, the IllegalAccessException is caught. The exception is re-thrown but the cause is lost.

mockito/src/main/java/org/mockito/internal/util/reflection/FieldReader.java

Lines 28 to 35 in ea000f7

	public Object read() {
	try {
	return accessor.get(field, target);
	} catch (Exception e) {
	throw new MockitoException(
	"Cannot read state from field: " + field + ", on instance: " + target);
	}
	}

Using a debugger, the IllegalAccessException can be observed: https://pastebin.com/GsnU29QV

Problematic Code

1. Use module-info in the project and don't open the package under test to mockito.

2. Use the MockitoExtension for JUnit:

@ExtendWith(MockitoExtension.class)
public class MyClassTest {

  private final MyType mock;

  public MyClassTest(@Mock MyType mock) {
    this.mock = mock;
  }
}

Environment

Mockito-Junit-Jupiter 3.9.0
Zulu16.28+11-CA (build 16+36)