New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI overhaul, migrated from Bintray #2243
Conversation
We need to remove the dependency on Bintray/JCenter
Codecov Report
@@ Coverage Diff @@
## release/3.x #2243 +/- ##
=================================================
- Coverage 84.87% 84.85% -0.03%
Complexity 2765 2765
=================================================
Files 328 328
Lines 8410 8410
Branches 1004 1004
=================================================
- Hits 7138 7136 -2
Misses 997 997
- Partials 275 277 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh actually, I think we need a similar fix to mockito/mockito-kotlin#425 where we have to drop the tags-ignore
from line 13 and match on tags of 3.*
" Github releases: SKIPPED FOR SNAPSHOTS" | ||
} else { | ||
println "RELEASE SUMMARY\n" + | ||
" Release to Maven Central (available in few hours): https://repo1.maven.org/maven2/org/mockito/mockito-core/\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did they degrade so much recently? It's true that the search index is updated after a few hours, but when I checked it a year ago (or so), the artifacts were available in https://repo1.maven.org/maven2/...
(and ready for usage in Gradle/Maven/...) after a few (maybe several) minutes.
You can check that with the next Mockito release and update that statement if needed (e.g. to change the hours to minutes :) ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
We need to remove the dependency on Bintray/JCenter