Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI overhaul, migrated from Bintray #2243

Merged
merged 9 commits into from May 10, 2021
Merged

CI overhaul, migrated from Bintray #2243

merged 9 commits into from May 10, 2021

Conversation

mockitoguy
Copy link
Member

We need to remove the dependency on Bintray/JCenter

@mockitoguy mockitoguy changed the title [WIP] CI overhaul CI overhaul, migrated from Bintray May 9, 2021
@mockitoguy mockitoguy marked this pull request as ready for review May 9, 2021 13:42
@mockitoguy mockitoguy requested a review from TimvdLippe May 9, 2021 14:30
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #2243 (1e20c69) into release/3.x (8f95dca) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2243      +/-   ##
=================================================
- Coverage          84.87%   84.85%   -0.03%     
  Complexity          2765     2765              
=================================================
  Files                328      328              
  Lines               8410     8410              
  Branches            1004     1004              
=================================================
- Hits                7138     7136       -2     
  Misses               997      997              
- Partials             275      277       +2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/Mockito.java 91.25% <ø> (ø) 56.00 <0.00> (ø)
...to/internal/util/concurrent/WeakConcurrentMap.java 37.37% <0.00%> (-2.03%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f95dca...1e20c69. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually, I think we need a similar fix to mockito/mockito-kotlin#425 where we have to drop the tags-ignore from line 13 and match on tags of 3.*

" Github releases: SKIPPED FOR SNAPSHOTS"
} else {
println "RELEASE SUMMARY\n" +
" Release to Maven Central (available in few hours): https://repo1.maven.org/maven2/org/mockito/mockito-core/\n" +
Copy link
Member

@szpak szpak May 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did they degrade so much recently? It's true that the search index is updated after a few hours, but when I checked it a year ago (or so), the artifacts were available in https://repo1.maven.org/maven2/... (and ready for usage in Gradle/Maven/...) after a few (maybe several) minutes.

You can check that with the next Mockito release and update that statement if needed (e.g. to change the hours to minutes :) ).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants