Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in the doc for "Mocking object construction" #2145

Merged

Conversation

kroening
Copy link
Contributor

This is a suggestion for changing the documentation for "Mocking object
construction". Previously, the documentation has suggested that
MockedConstruction can define mock behavior and to verify static method
invocations. However, it is meant for defining mock behavior and verifying
non-static method invocations.

  • Read the contributing guide
  • PR should be motivated, i.e. what does it fix, why, and if relevant how
  • If possible / relevant include an example in the description, that could help all readers
    including project members to get a better picture of the change
  • Avoid other runtime dependencies
  • Meaningful commit history ; intention is important please rebase your commit history so that each
    commit is meaningful and help the people that will explore a change in 2 years
  • The pull request follows coding style
  • Mention Fixes #<issue number> in the description if relevant
  • At least one commit should mention Fixes #<issue number> if relevant

This is a suggestion for changing the documentation for "Mocking object
construction".  Previously, the documentation has suggested that
MockedConstruction can define mock behavior and to verify static method
invocations.  However, it is meant for defining mock behavior and verifying
non-static method invocations.
@codecov-io
Copy link

codecov-io commented Dec 15, 2020

Codecov Report

Merging #2145 (aeb6fdd) into release/3.x (b10d833) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #2145      +/-   ##
=================================================
+ Coverage          84.88%   84.90%   +0.02%     
  Complexity          2721     2721              
=================================================
  Files                325      325              
  Lines               8277     8277              
  Branches             989      989              
=================================================
+ Hits                7026     7028       +2     
  Misses               980      980              
+ Partials             271      269       -2     
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/mockito/Mockito.java 91.02% <ø> (ø) 55.00 <0.00> (ø)
...to/internal/util/concurrent/WeakConcurrentMap.java 41.48% <0.00%> (+2.12%) 11.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10d833...aeb6fdd. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants