Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Bundle-Version manifest header when used in Eclipse PDE development #2083

Closed
joeshannon opened this issue Oct 28, 2020 · 2 comments

Comments

@joeshannon
Copy link
Contributor

The MANIFEST.MF currently contains e.g.: Bundle-version: 3.6.0

Due to the lowercase 'v' this appears to not be properly recognised by Eclipse PDE so is giving me errors on min versioned require bundle directives.

The standard headers at https://www.osgi.org/bundle-headers-reference/ define it as Bundle-Version (capital V).

After a small amount of research it looks like OSGi specification possibly does accept case insensitive headers but haven't found definitive source.

In any case, changing it would keep it consistant with the other headers.

joeshannon added a commit to joeshannon/mockito that referenced this issue Oct 28, 2020
OSGi specification may accept case insensitive headers but this is
causing problems for Eclipse PDE development with version constriants.

Switch to match casing of other headers and agree with name provided
at: https://www.osgi.org/bundle-headers-reference/
@TimvdLippe
Copy link
Contributor

Seems like we hit this issue after we fixed an initial typo in #2070. Do you mind sending a PR to change it to a capital V?

@joeshannon
Copy link
Contributor Author

Done, thanks for quick response!

holubec-petr pushed a commit to holubec-petr/mockito that referenced this issue Nov 20, 2020
…ockito#2084)

OSGi specification may accept case insensitive headers but this is
causing problems for Eclipse PDE development with version constraints.

Switch to match casing of other headers and agree with name provided
at: https://www.osgi.org/bundle-headers-reference/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants