JUnit 5 strict stubs check should not suppress the regular test failure #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the test fails, MockitoExtension should not check for strict stubs at the end of the test.
|
Good idea. Will review shortly. Thank you for the contribution! |
mockitoguy
requested changes
May 11, 2020
|
|
||
| assertThat(result.getStatus()).isEqualTo(TestExecutionResult.Status.FAILED); | ||
| Throwable throwable = result.getThrowable().get(); | ||
| assertThat(throwable).isInstanceOf(AssertionError.class); |
There was a problem hiding this comment.
Can you make the assertion stronger by using a more specific exception? You can create a custom exception type in the test.
There was a problem hiding this comment.
Ok, I see you already did it.
Codecov Report
@@ Coverage Diff @@
## release/3.x #1928 +/- ##
==============================================
Coverage 86.67% 86.67%
Complexity 2526 2526
==============================================
Files 318 318
Lines 6650 6650
Branches 832 832
==============================================
Hits 5764 5764
Misses 685 685
Partials 201 201
Continue to review full report at Codecov.
|
mockitoguy
changed the title
mockitoguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test fails, MockitoExtension should not check for strict stubs at the end of the test, because the possible UnnecessaryStubbingException will end up as a suppressed exception on the test's initial failure.