Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Mockito version number for deletion of deprecated classes #1868

Merged
merged 1 commit into from Jan 31, 2020
Merged

Update Mockito version number for deletion of deprecated classes #1868

merged 1 commit into from Jan 31, 2020

Conversation

scordio
Copy link
Contributor

@scordio scordio commented Jan 30, 2020

No description provided.

@@ -17,8 +17,6 @@
/**
* Handler, that call all listeners wanted for this mock, before delegating it
* to the parameterized handler.
*
* Also imposterize MockHandlerImpl, delegate all call of InternalMockHandler to the real mockHandler
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seemed to be a stale comment but I can restore it if it is not.

@bric3
Copy link
Contributor

bric3 commented Jan 30, 2020

Codecov Report

Merging #1868 into release/3.x will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             release/3.x    #1868   +/-   ##
==============================================
  Coverage          86.87%   86.87%           
+ Complexity          2517     2515    -2     
==============================================
  Files                314      313    -1     
  Lines               6619     6608   -11     
  Branches             831      831           
==============================================
- Hits                5750     5741    -9     
+ Misses               671      667    -4     
- Partials             198      200    +2     
Impacted Files Coverage Δ Complexity Δ
...al/creation/bytebuddy/SubclassInjectionLoader.java 52.63% <0.00%> (-21.06%) 6.00% <0.00%> (-1.00%)
...ito/internal/creation/bytebuddy/ModuleHandler.java 25.96% <0.00%> (-0.97%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2730c...6308d5d. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constitutes a breaking change which would cause us to release Mockito 4. We first need to finish the discussion in #1517 and define a timeline before we can make that happen.

@scordio
Copy link
Contributor Author

scordio commented Jan 30, 2020

Hi @TimvdLippe, thanks for the feedback! I was following the existing comments in the javadoc forgetting that it is already announced that Mockito 3 does not introduce any breaking change.

I just changed my commit, I would still fix the version number in the javadoc regarding the deletion plan.

@scordio scordio changed the title Delete deprecated classes already marked for deletion Update Mockito version number for deletion of deprecated classes Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020

Codecov Report

Merging #1868 into release/3.x will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1868      +/-   ##
=================================================
- Coverage          86.87%   86.85%   -0.02%     
+ Complexity          2517     2516       -1     
=================================================
  Files                314      314              
  Lines               6619     6619              
  Branches             831      831              
=================================================
- Hits                5750     5749       -1     
  Misses               671      671              
- Partials             198      199       +1
Impacted Files Coverage Δ Complexity Δ
...to/internal/handler/InvocationNotifierHandler.java 100% <ø> (ø) 8 <0> (ø) ⬇️
...n/java/org/mockito/runners/MockitoJUnitRunner.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ockito/internal/util/reflection/InstanceField.java 45.83% <0%> (-4.17%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2730c...129c61c. Read the comment docs.

Copy link
Contributor

@TimvdLippe TimvdLippe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs cleanup!

@TimvdLippe TimvdLippe merged commit da3f5d8 into mockito:release/3.x Jan 31, 2020
@scordio scordio deleted the delete_deprecated_classes branch February 2, 2020 07:56
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants