New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Mockito version number for deletion of deprecated classes #1868
Update Mockito version number for deletion of deprecated classes #1868
Conversation
@@ -17,8 +17,6 @@ | |||
/** | |||
* Handler, that call all listeners wanted for this mock, before delegating it | |||
* to the parameterized handler. | |||
* | |||
* Also imposterize MockHandlerImpl, delegate all call of InternalMockHandler to the real mockHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seemed to be a stale comment but I can restore it if it is not.
Codecov Report
@@ Coverage Diff @@
## release/3.x #1868 +/- ##
==============================================
Coverage 86.87% 86.87%
+ Complexity 2517 2515 -2
==============================================
Files 314 313 -1
Lines 6619 6608 -11
Branches 831 831
==============================================
- Hits 5750 5741 -9
+ Misses 671 667 -4
- Partials 198 200 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This constitutes a breaking change which would cause us to release Mockito 4. We first need to finish the discussion in #1517 and define a timeline before we can make that happen.
Hi @TimvdLippe, thanks for the feedback! I was following the existing comments in the javadoc forgetting that it is already announced that Mockito 3 does not introduce any breaking change. I just changed my commit, I would still fix the version number in the javadoc regarding the deletion plan. |
Codecov Report
@@ Coverage Diff @@
## release/3.x #1868 +/- ##
=================================================
- Coverage 86.87% 86.85% -0.02%
+ Complexity 2517 2516 -1
=================================================
Files 314 314
Lines 6619 6619
Branches 831 831
=================================================
- Hits 5750 5749 -1
Misses 671 671
- Partials 198 199 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs cleanup!
No description provided.