Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Performance optimization by using Method.getParameterCount() where possible" #1862

Merged
merged 1 commit into from Jan 27, 2020

Conversation

TimvdLippe
Copy link
Contributor

Reverts #1849

It breaks all downstream Android applications, see #1849 (comment)

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #1862 into release/3.x will decrease coverage by <.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1862      +/-   ##
=================================================
- Coverage          86.87%   86.87%   -0.01%     
+ Complexity          2518     2517       -1     
=================================================
  Files                314      314              
  Lines               6620     6619       -1     
  Branches             831      831              
=================================================
- Hits                5751     5750       -1     
  Misses               671      671              
  Partials             198      198
Impacted Files Coverage Δ Complexity Δ
...mockito/internal/invocation/InvocationMatcher.java 97.82% <0%> (ø) 25 <0> (-1) ⬇️
.../mockito/internal/invocation/TypeSafeMatching.java 88.23% <100%> (ø) 12 <3> (ø) ⬇️
...o/internal/stubbing/answers/ReturnsArgumentAt.java 100% <100%> (ø) 27 <4> (ø) ⬇️
...a/org/mockito/internal/util/ObjectMethodsGuru.java 100% <100%> (ø) 9 <0> (ø) ⬇️
...nal/creation/instance/ConstructorInstantiator.java 95.77% <100%> (ø) 36 <9> (ø) ⬇️
...ito/internal/util/reflection/FieldInitializer.java 90.56% <100%> (ø) 18 <0> (ø) ⬇️
...java/org/mockito/internal/exceptions/Reporter.java 93.54% <100%> (-0.03%) 93 <5> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c1aff...a7e17db. Read the comment docs.

@TimvdLippe
Copy link
Contributor Author

Approved per #1849 (comment)

@TimvdLippe TimvdLippe merged commit 34790ec into release/3.x Jan 27, 2020
@TimvdLippe TimvdLippe deleted the revert-1849-gh-1848 branch January 27, 2020 11:07
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants