Fixes #1853: Allow @MockitoSettings to be inherited #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
requested changes
Jan 2, 2020
Codecov Report
@@ Coverage Diff @@
## release/3.x #1854 +/- ##
==============================================
Coverage 86.87% 86.87%
Complexity 2518 2518
==============================================
Files 314 314
Lines 6620 6620
Branches 831 831
==============================================
Hits 5751 5751
Misses 671 671
Partials 198 198Continue to review full report at Codecov.
|
fabianMendez
force-pushed
the
inherit-mockito-settings
branch
from
fe3a45b
to
e90eba6
Compare
I've just amended the commit with a test |
fabianMendez
force-pushed
the
inherit-mockito-settings
branch
from
e90eba6
to
540c7c5
Compare
TimvdLippe
approved these changes
Jan 2, 2020
| private Function<Integer, String> rootMock; | ||
|
|
||
| @Test | ||
| void should_throw_an_exception_on_strict_stubs_configured_by_default() { |
There was a problem hiding this comment.
Nit: test name should be updated to state that it properly inherits from the MockitoSettings on the superclass.
fabianMendez
force-pushed
the
inherit-mockito-settings
branch
from
540c7c5
to
9c0bce0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant