Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add Duration overloads. Fixes #1815" #1845

Merged
merged 1 commit into from Dec 16, 2019

Conversation

TimvdLippe
Copy link
Contributor

Reverts #1818

Fixes #1843

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #1845 into release/3.x will increase coverage by 0.04%.
The diff coverage is 96%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/3.x    #1845      +/-   ##
=================================================
+ Coverage          86.64%   86.69%   +0.04%     
+ Complexity          2507     2505       -2     
=================================================
  Files                314      314              
  Lines               6613     6606       -7     
  Branches             829      829              
=================================================
- Hits                5730     5727       -3     
+ Misses               682      678       -4     
  Partials             201      201
Impacted Files Coverage Δ Complexity Δ
...java/org/mockito/internal/exceptions/Reporter.java 93.51% <ø> (ø) 93 <0> (ø) ⬇️
src/main/java/org/mockito/Mockito.java 96.77% <100%> (-0.11%) 42 <2> (-2)
...nternal/verification/VerificationOverTimeImpl.java 92.1% <100%> (ø) 16 <5> (ø) ⬇️
src/main/java/org/mockito/verification/After.java 100% <100%> (+22.22%) 4 <2> (ø) ⬇️
...rc/main/java/org/mockito/verification/Timeout.java 81.81% <100%> (+12.58%) 5 <3> (ø) ⬇️
...erification/VerificationWrapperInOrderWrapper.java 100% <100%> (ø) 6 <0> (ø) ⬇️
src/main/java/org/mockito/internal/util/Timer.java 85.71% <90%> (-0.96%) 8 <7> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 517facc...3106716. Read the comment docs.

@TimvdLippe TimvdLippe merged commit 1ce2078 into release/3.x Dec 16, 2019
@TimvdLippe TimvdLippe deleted the revert-1818-fix-1815 branch December 16, 2019 11:47
pull bot pushed a commit to scope-demo/mockito that referenced this pull request Dec 16, 2019
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.time.Duration not present before SDK 26
2 participants