Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indent with spaces using spotless #1820

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

TimvdLippe
Copy link
Contributor

Discovered in #1818 that (if new contributors are unaware of our indentation with 4 spaces), spotless did not fix the formatting. indentWithSpaces(4) does just that and it actually found other formatting issues.

Copy link
Contributor

@bric3 bric3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
Actually while I think that fixing those is nice. I think spotless is not about well chained method (on the the dot).

@TimvdLippe
Copy link
Contributor Author

Yes that is correct. I think at that point you need a formatter like google-java-formatter or eclipse-formatter to fix these kind of "aesthetics".

@TimvdLippe TimvdLippe merged commit 8f68572 into release/3.x Nov 7, 2019
@TimvdLippe TimvdLippe deleted the indent-with-spaces branch November 7, 2019 20:27
epeee pushed a commit to epeee/mockito that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants