Report initialization failures per test method #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, `DefaultInternalRunner` threw an exception when `MockitoAnnotations.initMocks()` failed from the overridden `withBefores` method. Instead, it now returns a `Statement` that is responsible for initializing. Potential exceptions are then handled by JUnit, regardless whether version 4.12 or 4.13-beta-2 is used. Instead of reporting a class-level error, JUnit will now report a failure for each test method in such test classes. Related issue: junit-team/junit4#1599
Codecov Report
@@ Coverage Diff @@
## release/2.x #1672 +/- ##
=================================================
+ Coverage 87.38% 87.39% +0.01%
Complexity 2446 2446
=================================================
Files 302 302
Lines 6326 6325 -1
Branches 788 787 -1
=================================================
Hits 5528 5528
Misses 603 603
+ Partials 195 194 -1
Continue to review full report at Codecov.
|
TimvdLippe
approved these changes
Mar 23, 2019
There was a problem hiding this comment.
Thanks for this @marcphilipp ! It is a minor change in event firing, but I think it is better to be consistent about it with both 4.12 and 4.13. Merging 😄
marcphilipp
added a commit
to marcphilipp/mockito
that referenced
this pull request
Nov 10, 2019
Some rules evaluate the base statement multiple times, e.g. to execute tests repeatedly. The changes made in mockito#1672 led to an exception in such cases because the `MockitoListener` was registered multiple times. Now, we only add the listener the first time the statement is evaluated in order to restore the old behavior. Fixes mockito#1767.
TimvdLippe
pushed a commit
that referenced
this pull request
Nov 10, 2019
* Guard against multiple evaluations of before statement Some rules evaluate the base statement multiple times, e.g. to execute tests repeatedly. The changes made in #1672 led to an exception in such cases because the `MockitoListener` was registered multiple times. Now, we only add the listener the first time the statement is evaluated in order to restore the old behavior. Fixes #1767. * Reset listener when removing it
epeee
pushed a commit
to epeee/mockito
that referenced
this pull request
Jun 22, 2020
* Guard against multiple evaluations of before statement Some rules evaluate the base statement multiple times, e.g. to execute tests repeatedly. The changes made in mockito#1672 led to an exception in such cases because the `MockitoListener` was registered multiple times. Now, we only add the listener the first time the statement is evaluated in order to restore the old behavior. Fixes mockito#1767. * Reset listener when removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit,
DefaultInternalRunnerthrew an exception whenMockitoAnnotations.initMocks()failed from the overriddenwithBeforesmethod. Instead, it now returns aStatementthat isresponsible for initializing. Potential exceptions are then handled by
JUnit, regardless whether version 4.12 or 4.13-beta-2 is used. Instead
of reporting a class-level error, JUnit will now report a failure for
each test method in such test classes.
Related issue: junit-team/junit4#1599
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant