Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NPE in findTypeFromGenericInArguments #1648

Merged
merged 3 commits into from Mar 5, 2019

Conversation

TimvdLippe
Copy link
Contributor

There was only a single test failing on this. I think the issue was RETURNS_SMART_NULLS in combination with an ArgumentCaptor, but
couldn't figure that part out. At least this fixes prevented the NPE.

There was only a single test failing on this. I think the issue was RETURNS_SMART_NULLS in combination with an ArgumentCaptor, but
couldn't figure that part out. At least this fixes prevented the NPE.
@TimvdLippe TimvdLippe requested a review from raphw March 4, 2019 18:22
Copy link
Member

@raphw raphw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot really forsee the consequences of this but it does not seem like a problem, especially since a null pointer is never a good outcome. Can we support this with a test case?

@TimvdLippe TimvdLippe merged commit 1183d1f into release/2.x Mar 5, 2019
@TimvdLippe TimvdLippe deleted the TimvdLippe-patch-1 branch March 5, 2019 15:34
@codecov-io
Copy link

codecov-io commented Mar 5, 2019

Codecov Report

Merging #1648 into release/2.x will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##             release/2.x    #1648      +/-   ##
=================================================
+ Coverage          87.37%   87.38%   +<.01%     
- Complexity          2434     2435       +1     
=================================================
  Files                301      301              
  Lines               6275     6278       +3     
  Branches             783      784       +1     
=================================================
+ Hits                5483     5486       +3     
  Misses               596      596              
  Partials             196      196
Impacted Files Coverage Δ Complexity Δ
...aultanswers/RetrieveGenericsForDefaultAnswers.java 96.15% <100%> (+0.23%) 21 <0> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cf3822...2894895. Read the comment docs.

@mockitoguy
Copy link
Member

Nice change, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants