Fixes #1578: outer class mocks unavailable from inner class #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimvdLippe
requested changes
Jan 28, 2019
src/test/java/org/mockito/internal/junit/util/HierarchicalJUnitRuleTest.java
Outdated
Show resolved
Hide resolved
- Problem - JUnitRule detects an unfinished mocking session when the apply method is invoked more than once. This commonly happens with Runners that enable developers to write nested test classes. - Fix - If a MockitoSession has been established for JUnitRule, then use that and initialize any new mocks (typically from a nested test class). - Test - Instantiate one @rule and assign it to a second one. This will simulate the apply method being invoked more than once without introducing a new test dependency.
Codecov Report
@@ Coverage Diff @@
## release/2.x #1596 +/- ##
=================================================
+ Coverage 87.54% 87.54% +<.01%
Complexity 2437 2437
=================================================
Files 300 300
Lines 6255 6257 +2
Branches 775 776 +1
=================================================
+ Hits 5476 5478 +2
Misses 582 582
Partials 197 197
Continue to review full report at Codecov.
|
SamBarker
pushed a commit
to SamBarker/mockito
that referenced
this pull request
Feb 25, 2019
…ckito#1596) - Problem - JUnitRule detects an unfinished mocking session when the apply method is invoked more than once. This commonly happens with Runners that enable developers to write nested test classes. - Fix - If a MockitoSession has been established for JUnitRule, then use that and initialize any new mocks (typically from a nested test class). - Test - Instantiate one @rule and assign it to a second one. This will simulate the apply method being invoked more than once without introducing a new test dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened issue #1578 a few weeks ago that went without an correspondence, so I apologize if submitting a PR isn't the ideal method of moving this issue forward. However I am hoping I can get this fix incorporated into an official version without implementing temporary workarounds.
The PR should clearly show the issue I am trying to fix, but I had to introduce a testCompile snapshot dependency. The dependent project has a fix required to demonstrate the issue within Mockito but it unfortunately has not been incorporated into an official release, and I can't think of another way to reproduce the issue. I have contacted the owner of the dependent project but I haven't received a response from them either.
I am looking for guidance on next steps for what I believe to be regression (reported to be working in #353). The only other solution I can think of is to merge this without a unit test but I highly doubt that is desirable.
Git Commit Message