Update bytebuddy, asm and objenesis for full Java 11 support #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @raphw |
ijuma
commented
Oct 30, 2018
gradle/dependencies.gradle
Outdated
| @@ -20,9 +20,9 @@ libraries.bytebuddyandroid = "net.bytebuddy:byte-buddy-android:${versions.bytebu | |||
|
|
|||
| libraries.errorprone = 'com.google.errorprone:error_prone_core:2.3.1' | |||
|
|
|||
| libraries.objenesis = 'org.objenesis:objenesis:2.6' | |||
| libraries.objenesis = 'org.objenesis:objenesis:3.0.1' | |||
There was a problem hiding this comment.
Version 3.0.1 requires Java 8. If this is an issue, we need to keep using the older version.
There was a problem hiding this comment.
I reverted this change.
Codecov Report
@@ Coverage Diff @@
## release/2.x #1525 +/- ##
==============================================
Coverage 88.59% 88.59%
Complexity 2401 2401
==============================================
Files 299 299
Lines 6039 6039
Branches 733 733
==============================================
Hits 5350 5350
Misses 510 510
Partials 179 179Continue to review full report at Codecov.
|
|
Forgot to update ASM there, Byte Buddy bundles its own. LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check list
including project members to get a better picture of the change
commit is meaningful and help the people that will explore a change in 2 years
Fixes #<issue number>in the description if relevantFixes #<issue number>if relevant