Allow mockito-logger to be configurable as Mockito extension #1430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedla
force-pushed
the
logger-extension
branch
2 times, most recently
from
ab12d97
to
0ede2b0
Compare
Codecov Report
@@ Coverage Diff @@
## release/2.x #1430 +/- ##
=================================================
+ Coverage 87.53% 87.54% +<.01%
- Complexity 2435 2437 +2
=================================================
Files 300 300
Lines 6250 6255 +5
Branches 775 775
=================================================
+ Hits 5471 5476 +5
Misses 582 582
Partials 197 197
Continue to review full report at Codecov.
|
|
+1 |
bedla
changed the title
bedla
force-pushed
the
logger-extension
branch
from
5e66847
to
957ed86
Compare
bedla
force-pushed
the
logger-extension
branch
from
e8c2eea
to
50b2366
Compare
bedla
force-pushed
the
logger-extension
branch
from
50b2366
to
c9c42ac
Compare
bedla
force-pushed
the
logger-extension
branch
from
c9c42ac
to
94122e6
Compare
bedla
force-pushed
the
logger-extension
branch
from
94122e6
to
7f60590
Compare
bric3
approved these changes
Nov 20, 2018
bedla
force-pushed
the
logger-extension
branch
from
7f60590
to
d0ee7af
Compare
|
rebased with current upstream |
TimvdLippe
requested changes
Jan 28, 2019
| @@ -2,7 +2,7 @@ | |||
| * Copyright (c) 2007 Mockito contributors | |||
| * This program is made available under the terms of the MIT License. | |||
| */ | |||
| package org.mockito.internal.util; | |||
| package org.mockito.plugins; | |||
|
|
|||
| public interface MockitoLogger { | |||
There was a problem hiding this comment.
We are going to need some additional documentation here. https://static.javadoc.io/org.mockito/mockito-core/2.23.4/org/mockito/plugins/MockMaker.html is probably a good starting point of what we can add as documentation.
There was a problem hiding this comment.
done, i hope that description is sufficient :]
bedla
force-pushed
the
logger-extension
branch
from
d0ee7af
to
ee37eed
Compare
|
thx a lot ;] |
SamBarker
pushed a commit
to SamBarker/mockito
that referenced
this pull request
Feb 25, 2019
SamBarker
pushed a commit
to SamBarker/mockito
that referenced
this pull request
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we have many of legacy tests that do over-mocking code base - lots of unused mocking there (we are cleaning it slowly). We have user
@MockitoSettings(strictness = Strictness.WARN)switch to log and not fail in this situactions. By default all logs are printed out to console usingSystem.out.printlnand this make us trouble because we have "silent" profile at CI server which is configured to silent Loggers / as you expect sith.printlnwe are not trully silent in this case :]Thats why I have created this PR proposal and want to know what do you think.
Thx,
Ivos