Fix chained demeter calls with type hint #956
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation fails in the following situation:
In this case, if
getCustomer
has a type hint for return type, the mock for getLastName will not work. This happens because the named mock doesn't have the prefixMockery_<count>__
, so instead ofMockery_1__demeter_02db565163e0992acfde42edfd58d833_getCustomer
, it will be named onlydemeter_02db565163e0992acfde42edfd58d833_getCustomer
.Because of that, the method
Container::getKeyOfDemeterMockFor
will not be able to find the mock.Some users complained about this problem in some already closed issues: