Fix mocking with classes that use HHVM memoization #893
+28
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davedevelopment sorry for the Git noob-ery here - this is my replacement PR for #892. Any chance it could get merged? |
|
No worries at all, thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HHVM has a built-in decorator that memoizes class methods. However, its implementation is incompatible with the code generation/evaluation strategy that Mockery uses.
This PR fixes Mockery to allow mocking of classes that use the decorator, though with the caveat that the decorator will no longer function as advertised. This is regrettable, but memoization (as implemented by HHVM) is solely a means of improving performance, and so disabling it in tests should not greatly affect behavior.