[1.4] Fix auto-generated return values with union types #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davedevelopment definitely not want to pressure you (take your time) but this is the last thing we need to provide PHP 8.1 support in Laravel. Would be cool if we could merge and tag this soon! :) |
9 tasks
|
No worries, will tag shortly |
|
Thanks @davedevelopment! Appreciate it 👍 |
|
I'm sorry @davedevelopment, seems like there are a couple of more snags to be solved before we have PHP 8.1 support in Laravel. But this PR definitely brought us closer so thank you! |
|
@driesvints no worries, good luck :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #1143 for the 1.4 branch. Easier than dealing with those merge PRs.
Blocks laravel/framework#38404. cc @davedevelopment, @driesvints.