[1.3] More fixes for PHP 8.1 and setup CI again #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this PR is merged, actions should run automatically. Here's the run from my fork:
|
GrahamCampbell
changed the title
|
Thanks Graham! Will this be merged in master then as soon as possible so our builds on laravel/framework can pass? |
|
After this reaches 1.3, I can do a 1.3 -> master merge PR. :) |
|
Away at the minute, but had a quick glance and all seems reasonable |
|
Was this merged into 1.4 dev? Because we're still getting failures for this: https://github.com/laravel/framework/runs/3449821860#step:7:82 |
|
No, not yet. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the outstanding issues with
Serializablemocking. I've also moved us to GitHub Actions since Travis is not running properly - it also looks like there's been no successful scrutinizer runs in over 4 years, so I've removed that guff from here. If we really wanna re-enable it, that can happen in a later PR. I'd probably prefer to enable an OSS static analyzer on the master branch, instead.cc @davedevelopment, @driesvints