Support for PHP 8 #1072
Merged
Support for PHP 8 #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Jul 5, 2020
Closed
|
Amazing Graham, thank you. |
|
@davedevelopment Would you like me to prep a PR which does a 1.3 -> master branch merge for you? There will definitely be conflicts, and I should be in a good position to resolve them, with these changes fresh in my mind. :) |
|
@GrahamCampbell you're definitely welcome to, but I'm happy putting aside some time to do so this week and it will help me familiarise myself with the changes 馃憤 |
|
I'll start doing the merge in 10 minutes or so. :) |
17 tasks
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets Mockery working properly on PHP 8. All the bells and whistles! 馃殌
EDIT: I have targetted this at 1.3 on purpose, with the aim of having a 1.3.2 release later. I'm happy to also handle merging 1.3 -> master after this PR is finished with. I'd also be happy to backport any important fixes from master to 1.3 over the next 15 months (or even encourage contributors to send to 1.3, initially).
Closes #1071. Closes #1074. Related to hamcrest/hamcrest-php#65, laravel/framework#33039, sebastianbergmann/phpunit#4325.