Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Repo: Two-column lists in the docs should not be the default style for lists! #3702

Open
boneskull opened this issue Jan 29, 2019 · 3 comments · May be fixed by #5110
Open

🛠️ Repo: Two-column lists in the docs should not be the default style for lists! #3702

boneskull opened this issue Jan 29, 2019 · 3 comments · May be fixed by #5110
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!

Comments

@boneskull
Copy link
Member

boneskull commented Jan 29, 2019 •
edited

This should not be the default list style:

image

Change the stylesheet to display a "normal" list unless we apply a specific class for two-column display. I think it's OK to use in some places, but not for all lists.

unless there's a way to specify the class in our markdown compiler (not sure), just use html for the ones we keep. features and table of contents are good to keep... not sure about the rest.

For implementors:

To see changes locally, run npm start docs and open up docs/_dist/index.html with your browser. You can also do npm start docs.watch to rebuild as you work (you'll still have to reload).
@boneskull boneskull added status: accepting prs Mocha can use your help with this one! area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! labels Jan 29, 2019
@tild4-d33
Copy link

tild4-d33 commented Feb 3, 2019 •
edited

would like to take this one. had to reconfigure "wd" module with fresh install to get tests to pass.

tild4-d33 added a commit to tild4-d33/mocha that referenced this issue Feb 3, 2019
@tild4-d33
closes mochajs#3702 default column CSS
06ba8ab
@boneskull
Copy link
Member Author

@crossaaron the wd module is only used for tests on SauceLabs, which you aren't running locally, so not sure what the problem was there.

at any rate, changes here should not affect any browser tests; the only potential failure would be a linting error.

@tild4-d33 tild4-d33 mentioned this issue Mar 6, 2019
Closed
@JoshuaKGoldberg JoshuaKGoldberg changed the title two-column lists in the docs should not be the default style for lists! 🛠️ Repo: Two-column lists in the docs should not be the default style for lists! Dec 27, 2023
marjys added a commit to marjys/mocha that referenced this issue Mar 3, 2024
@marjys
style: closes mochajs#3702
422563d 
- Adds the two-column class with the expected style for two-column unordered lists, making sure to keep the two-column style at Features and Table of Contents
- Removes column style from ul element scope
@marjys marjys linked a pull request Mar 3, 2024 that will close this issue
Open
3 tasks
@marjys
Copy link

marjys commented Mar 3, 2024

Hi! I'm new to Open Source and was looking for a good first issue to start contributing. May I give it a try? (#3702)
Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one!
Projects
None yet
Milestone
No milestone
3 participants
@boneskull @marjys @tild4-d33