Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESM: remove code for Node v12 #4874

Merged
merged 2 commits into from Apr 24, 2022
Merged

ESM: remove code for Node v12 #4874

merged 2 commits into from Apr 24, 2022

Conversation

juergba
Copy link
Member

@juergba juergba commented Apr 20, 2022

Description

Node version v12 has been dropped in #4845.

We remove ESM code which adressed Node versions <= 12.

@juergba juergba self-assigned this Apr 20, 2022
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-major implementation requires increase of "major" version number; "breaking changes" area: node.js command-line-or-Node.js-specific labels Apr 20, 2022
@juergba juergba added this to the v10.0.0 milestone Apr 20, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 94.328% when pulling 15353fe on juergba/esm-cleanup into 59f6192 on master.

@juergba juergba merged commit f6695f0 into master Apr 24, 2022
@juergba juergba deleted the juergba/esm-cleanup branch April 24, 2022 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees

@juergba juergba

Labels
area: node.js command-line-or-Node.js-specific semver-major implementation requires increase of "major" version number; "breaking changes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juergba @coveralls @outsideris