Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: conditionally skip 'push' event #4872

Merged
merged 1 commit into from Apr 19, 2022
Merged

CI: conditionally skip 'push' event #4872

merged 1 commit into from Apr 19, 2022

Conversation

juergba
Copy link
Member

@juergba juergba commented Apr 17, 2022 •
edited

Description

When a maintainer pushes a commit to a feature branch linked to an open PR, two events push and pull_request are emitted. To prevent our workflow Tests from executing twice, we skipped the pull_request workflow.

As a consequence coveralls doesn't work correctly anymore since it's based somehow on the pull_request event.

For forked PR's there is only one event emitted which is pull_request.

Description of the Change

On a push event we check with gh-find-current-pr wether an open PR exists. If yes, then we skip the push workflow. So before this PR, we skipped the pull_request event, now we skip the push event.

@coveralls
Copy link

coveralls commented Apr 17, 2022 •
edited

Coverage Status

Coverage remained the same at 94.335% when pulling 704fe88 on juergba/gha-double into baaa41a on master.

@juergba juergba marked this pull request as ready for review April 18, 2022 07:20
@juergba juergba self-assigned this Apr 18, 2022
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Apr 18, 2022
@juergba juergba added this to the v10.0.0 milestone Apr 18, 2022
@juergba juergba added qa and removed type: chore generally involving deps, tooling, configuration, etc. labels Apr 18, 2022
outsideris
outsideris approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juergba juergba merged commit 59f6192 into master Apr 19, 2022
@juergba juergba deleted the juergba/gha-double branch April 19, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees

@juergba juergba

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v10.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juergba @coveralls @outsideris