Fix: wrong error thrown while loading config files #4832
Merged
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
area: node.js
juergba
changed the title
KuznetsovRoman
pushed a commit
to gemini-testing/mocha
that referenced
this pull request
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While loading a js/cjs config file, Mocha uses the cwd-realtive path and as a fallback the module-relative path.
Edge case: a config file is successfully found, but its loading fails due to a bad require. There is no sense in using the fallback for a second file search which results in an incorrect error message.
Description of the Change
We add a
require.resolve()check which throws in case no config file can be found on the cwd-relative path. If it fails, retry again using the fallback path.Applicable issues
closes #4781