Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 'linkify-changelog.js' by switching to ESM #4812

Merged
merged 2 commits into from Jan 17, 2022
Merged

Fix 'linkify-changelog.js' by switching to ESM #4812

merged 2 commits into from Jan 17, 2022

Conversation

juergba
Copy link
Member

@juergba juergba commented Jan 15, 2022

Description

Some months ago I updated all remark* devDependencies, which meanwhile are pure ESM packages.
Therefore scripts/linkify-changelog.js is not working anymore. This script is used only for publishing Mocha to npm.

Description of the Change

  • migrate linkify-changelog.js to ESM linkify-changelog.mjs
  • remove devDependency to-vfile
  • update CHANGELOG.md

@juergba juergba self-assigned this Jan 15, 2022
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Jan 15, 2022
@juergba juergba added this to the next milestone Jan 15, 2022
@juergba juergba requested a review from a team January 15, 2022 10:41
@giltayar
Copy link
Contributor

LGTM.

BTW, you didn't HAVE to switch to ESM, because await import(...) works in CJS. But this is nicer.

@mochajs mochajs deleted a comment from Adsgw Jan 17, 2022
@juergba juergba merged commit f297790 into master Jan 17, 2022
@juergba juergba deleted the juergba/remark branch January 17, 2022 08:17
KuznetsovRoman pushed a commit to gemini-testing/mocha that referenced this pull request Sep 6, 2022
@juergba @KuznetsovRoman
chore: switch 'linkify-changelog.js' to ESM (mochajs#4812) [ci skip]
3582ff6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giltayar giltayar giltayar approved these changes

Assignees

@juergba juergba

Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juergba @giltayar