Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website: improve backers' sprite image #4756

Merged
merged 1 commit into from Sep 27, 2021
Merged

Website: improve backers' sprite image #4756

merged 1 commit into from Sep 27, 2021

Conversation

juergba
Copy link
Member

@juergba juergba commented Sep 27, 2021

Description

We have backer images with width<32px. The current spritesheet looks like this:

image

After this PR:

image

Description of the Change

We add -sprite-padding: 0 10; to the CSS class backer. I got this solution from assetgraph-builder maintainers in gitter chanel.
This change has no effect on netlify deploy-previews, since the sprite image is generated for production deploys only.

Applicable issues

closes #4752

@juergba juergba self-assigned this Sep 27, 2021
@juergba juergba added semver-patch implementation requires increase of "patch" version number; "bug fixes" area: website involving mochajs.org, but not necessarily involving docs labels Sep 27, 2021
@juergba juergba requested a review from a team September 27, 2021 07:29
@juergba juergba merged commit 0ea732c into master Sep 27, 2021
@juergba juergba deleted the juergba/sprite branch September 27, 2021 17:45
@juergba juergba added this to the next milestone Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: website involving mochajs.org, but not necessarily involving docs semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Webpage: some logos of our backers look weird
2 participants