Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print wrong count concurrent jobs in debug log #4415

Closed
outsideris opened this issue Aug 25, 2020 · 1 comment
Closed

Print wrong count concurrent jobs in debug log #4415

outsideris opened this issue Aug 25, 2020 · 1 comment
Labels
area: parallel mode Regarding parallel mode type: bug a defect, confirmed by a maintainer

Comments

@outsideris
Copy link
Member

Description

In mocha:cli:run:helpers debug logs, it will print current concurrent jobs like below:

$ DEBUG=mocha:cli:run:helpers ./bin/mocha --parallel -jobs=3 sample.test.js
  mocha:cli:run:helpers files (in order):  [ '/Users/jeonghoon/Dropbox/projects/github/mocha/tt.js' ] +0ms
  mocha:cli:run:helpers executing 1 test file(s) across 3 concurrent jobs +0ms

But without --jobs option, it prints NaN.

$ DEBUG=mocha:cli:run:helpers ./bin/mocha --parallel sample.test.js
  mocha:cli:run:helpers files (in order):  [ '/Users/jeonghoon/Dropbox/projects/github/mocha/tt.js' ] +0ms
  mocha:cli:run:helpers executing 1 test file(s) across NaN concurrent jobs +0ms

Steps to Reproduce

Run mocha with --parallel option but, without --jobs option.

$ DEBUG=mocha:cli:run:helpers ./bin/mocha --parallel sample.test.js

Expected behavior: [What you expect to happen]
Print current concurrent job count instead NaN.

Versions

  • The output of mocha --version and node node_modules/.bin/mocha --version: 8.1.1
  • The output of node --version: v12.18.1
  • Your operating system
    • name and version: macOS
    • architecture (32 or 64-bit): 64bit
  • Your shell (e.g., bash, zsh, PowerShell, cmd): zsh
@boneskull
Copy link
Member

boneskull commented Oct 16, 2020

fixed in #4416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: parallel mode Regarding parallel mode type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants