Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixing typo and org members link in CONTRIBUTING.md #4413

Merged
merged 1 commit into from Aug 22, 2020
Merged

fix: Fixing typo and org members link in CONTRIBUTING.md #4413

merged 1 commit into from Aug 22, 2020

Conversation

sujin-park
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Fixing typos and org member link in CONTRIBUTING.md file.

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

People will be able to see and click on the links, and get to the content they expected.

Possible Drawbacks

N/A

Applicable issues

N/A

@sujin-park sujin-park closed this Aug 19, 2020
@sujin-park sujin-park deleted the sujin-park/fix-typo-link branch August 19, 2020 12:42
@coveralls
Copy link

coveralls commented Aug 19, 2020 •
edited

Coverage Status

Coverage increased (+0.06%) to 93.849% when pulling fe21f89 on sujin-park:sujin-park/fix-typo-link into 667e9a2 on mochajs:master.

@sujin-park sujin-park reopened this Aug 19, 2020
outsideris
outsideris approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@outsideris outsideris merged commit 4d7a171 into mochajs:master Aug 22, 2020
irrationnelle pushed a commit to irrationnelle/mocha that referenced this pull request Aug 23, 2020
@sujin-park @irrationnelle
fix typo & org members link in CONTRIBUTING.md (mochajs#4413)
57684cb
@boneskull boneskull added this to the next milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v8.1.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sujin-park @coveralls @outsideris @boneskull