Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing typos #4404

Merged
merged 3 commits into from Aug 17, 2020
Merged

Fixing typos #4404

merged 3 commits into from Aug 17, 2020

Conversation

donghoon-song
Copy link
Contributor

@donghoon-song donghoon-song commented Aug 11, 2020 •
edited

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Fixing typos

Alternate Designs

N/A

Why should this be in core?

N/A

Benefits

Avoid confusion which comes from the wrong comments.

Possible Drawbacks

N/A

Applicable issues

N/A

@jsf-clabot
Copy link

jsf-clabot commented Aug 11, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Aug 11, 2020 •
edited

Coverage Status

Coverage increased (+0.06%) to 93.849% when pulling 52a3d6b on Donghoon759:fix-typo into 78d979d on mochajs:master.

@donghoon-song donghoon-song changed the title Fix typo in serializer Fixing typos Aug 11, 2020
@outsideris
Copy link
Member

Please sign CLA.

@outsideris
Copy link
Member

Thank you.

@outsideris outsideris merged commit 4e2b47d into mochajs:master Aug 17, 2020
irrationnelle pushed a commit to irrationnelle/mocha that referenced this pull request Aug 23, 2020
@donghoon-song @irrationnelle
Fixing typos (mochajs#4404)
2c2bb5b 
* Fix typo

* Fix typos

* Fix netlify deploy preview issue
@boneskull boneskull added this to the next milestone Aug 25, 2020
@boneskull boneskull added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Aug 28, 2020
@donghoon-song donghoon-song deleted the fix-typo branch September 12, 2020 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

@dasilvacontin dasilvacontin dasilvacontin approved these changes

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v8.1.2
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@donghoon-song @jsf-clabot @coveralls @outsideris @dasilvacontin @boneskull