Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Runnable#inspect and utils.ngettext #4230

Merged
merged 2 commits into from Apr 20, 2020
Merged

Remove Runnable#inspect and utils.ngettext #4230

merged 2 commits into from Apr 20, 2020

Conversation

juergba
Copy link
Member

@juergba juergba commented Apr 18, 2020

Description of the Change

  • Runnable#inspect: this function is never referenced
  • utils.ngettext: pointless twist-simple-to-complex function, used once

@juergba juergba self-assigned this Apr 18, 2020
@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Apr 18, 2020
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 93.06% when pulling d3f621d on juergba/remove-functions into 8236ffd on master.

@juergba juergba requested a review from a team April 18, 2020 08:35
Munter
Munter approved these changes Apr 19, 2020
View reviewed changes
Copy link
Member

@Munter Munter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

@juergba juergba merged commit 38d579a into master Apr 20, 2020
@juergba juergba deleted the juergba/remove-functions branch April 20, 2020 05:14
@juergba juergba added this to the next milestone Apr 20, 2020
juergba added a commit that referenced this pull request Apr 25, 2020
@juergba
Remove Runnable#inspect() and utils.ngettext() (#4230)
eba6ec7
@juergba juergba added the landed-on-v7.1.x cherry-picked from master label Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Munter approved these changes

Assignees

@juergba juergba

Labels
landed-on-v7.1.x cherry-picked from master semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v7.1.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@juergba @coveralls @Munter