Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(documentation) Inconsistent formatting of reporter names #4054

Closed
Lindsay-Needs-Sleep opened this issue Oct 8, 2019 · 0 comments · Fixed by #4127
Closed

(documentation) Inconsistent formatting of reporter names #4054

Lindsay-Needs-Sleep opened this issue Oct 8, 2019 · 0 comments · Fixed by #4127
Labels
area: documentation anything involving docs or mochajs.org

Comments

@Lindsay-Needs-Sleep
Copy link
Contributor

Lindsay-Needs-Sleep commented Oct 8, 2019

The report section of the documentation has inconsistent formatting.

eg:

  • The xunit reporter..
  • The Landing Strip (landing) reporter...
  • The dot matrix (or "dot") reporter...
  • The "min" reporter...
  • This is the default reporter. The "spec" reporter...
  • The HTML reporter...

I believe the main purpose of the quoted or code-blocked text is to tell you what exact string names you should use when indicating your desired reporter. I would say none of these formats do a good job at explicitly stating that. It is more a hint that you then have to use as a guess.

Additionally, it appears that the reporters have multiple acceptable names. (Possibly dependent on whether you are running in node or on the browser?)

In addition to the existing formats, I would like to suggest a format something like this for clarity:

JSON Stream

Names: "JSONStream" or "json-stream"
The JSON stream reporter outputs newline-delimited JSON "events" as they occur, beginning with a "start" event, followed by test passes or failures, and then the final "end" event.

(Or maybe no alternate names at all? [Their existence seems to be unnecessary, separate issue in the possible future. Though, if people agree that the alternate names should not be encouraged, then only the preferred name should be in the documentation.])

I created this issue because I didn't realize just making the the reporters all follow the most common format would be a big deal. I had originally tacked this onto a different PR. It has since been removed. Another issue I created also attracted similar attention.

Here are the previously mentioned issues / pull requests:

I will be stepping back from this conversation as I don't have a very strong opinion about this either way, and have already spent way to much time redoing commits for this cosmetic change.

@outsideris outsideris added type: bug a defect, confirmed by a maintainer area: documentation anything involving docs or mochajs.org and removed unconfirmed-bug labels Dec 14, 2019
@juergba juergba removed the type: bug a defect, confirmed by a maintainer label Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: documentation anything involving docs or mochajs.org
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants