Mocha constructor: some fixes and cleanup #4004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
type: bug
juergba
force-pushed
the
juergba/mocha-constructor
branch
4 times, most recently
from
2068424
to
897b917
Compare
juergba
force-pushed
the
juergba/mocha-constructor
branch
from
897b917
to
4c40c8a
Compare
|
I will merge this PR within the next few days. |
craigtaub
reviewed
Sep 20, 2019
juergba
force-pushed
the
juergba/mocha-constructor
branch
from
4c40c8a
to
32d0106
Compare
holm
pushed a commit
to peakon/mocha
that referenced
this pull request
Jan 14, 2020
In mochajs#4004 there was a change to use the documented `reporterOption` in favour of the setting that had always been used in practice called `reporterOptions`. This broke a lot of configurations that used the `reporterOptions`, which was the only way it every worked AFAIK. This changes the documentation to specify `reporterOptions` instead and ensure that any one that has switched to `reporterOption` after upgrade, still works.
holm
pushed a commit
to peakon/mocha
that referenced
this pull request
Jan 19, 2020
In mochajs#4004 there was a change to use the documented `reporterOption` in favour of the setting that had always been used in practice called `reporterOptions`. This broke a lot of configurations that used the `reporterOptions`, which was the only way it every worked AFAIK. This changes the documentation to specify `reporterOptions` instead and ensure that any one that has switched to `reporterOption` after upgrade, still works.
holm
pushed a commit
to peakon/mocha
that referenced
this pull request
Jan 19, 2020
In mochajs#4004 there was a change to use the documented `reporterOption` in favour of the setting that had always been used in practice called `reporterOptions`. This broke a lot of configurations that used the `reporterOptions`, which was the only way it every worked AFAIK. This changes the documentation to specify `reporterOptions` instead and ensure that any one that has switched to `reporterOption` after upgrade, still works.
holm
pushed a commit
to peakon/mocha
that referenced
this pull request
Jan 20, 2020
In mochajs#4004 there was a change to use the documented `reporterOption` in favour of the setting that had always been used in practice called `reporterOptions`. This broke a lot of configurations that used the `reporterOptions`, which was the only way it every worked AFAIK. This changes the documentation to specify `reporterOptions` instead and ensure that any one that has switched to `reporterOption` after upgrade, still works.
76 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Mocha is launched via CLI a whole bunch of options is dumped into the
mochainstance, like canonical / canonical camel-cased / alias / alias camel-cased versions of option names. This is prone to errors, but not part of this PR ==> see #4011.When the user manually calls the
Mochaconstructor, there are some bugs to be fixed.Furthermore we remove two deprecated options.
Description of the Change
enableTimeoutsoptionuseColorsoptionignoreLeaksoption: this option does not exist and is redundant tocheckLeaksinlineDiffsoption:useInlineDiffsdoes not existdiffoption:hideDiffdoes not existreporterOptionoption: its aliasreporterOptionswas processed insteadfullTrace:fullStackTracedoes not existglobaloption: no alias processingThis is a breaking change.