Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad option with mocha v6.x #3791

Closed
4 tasks done
XhmikosR opened this issue Mar 2, 2019 · 2 comments
Closed
4 tasks done

bad option with mocha v6.x #3791

XhmikosR opened this issue Mar 2, 2019 · 2 comments
Labels
type: bug a defect, confirmed by a maintainer

Comments

@XhmikosR
Copy link
Contributor

XhmikosR commented Mar 2, 2019

Prerequisites

  • Checked that your issue hasn't already been filed by cross-referencing issues with the faq label
  • Checked next-gen ES issues and syntax problems by using the same environment and/or transpiler configuration without Mocha to ensure it isn't just a feature that actually isn't supported in the environment in question or a bug in your code.
  • 'Smoke tested' the code to be tested by running it outside the real test suite to get a better sense of whether the problem is in the code under test, your usage of Mocha, or Mocha itself
  • Ensured that there is no discrepancy between the locally and globally installed versions of Mocha. You can find them with: node node_modules/.bin/mocha --version(Local) and mocha --version(Global). We recommend that you not install Mocha globally.

Description

Since mocha v6.0.0, I've been getting:

C:\Program Files\nodejs\node.exe: bad option: --throw-deprecation --trace-deprecation --trace-warnings --use_strict

Steps to Reproduce

git clone https://github.com/MaxCDN/bootstrapcdn.git -b develop-xmr-update-mocha
npm i
npm test

Expected behavior: [What you expect to happen]

No error to be thrown

Reproduces how often:

100%

Versions

  • Node.js v10.15.2
  • npm 6.4.1
  • mocha 6.0.2
  • OS is irrelevant

Additional Information

test/mocha.opts:

--check-leaks
--globals __core-js_shared__
--reporter dot
--throw-deprecation
--timeout 10000
--trace-deprecation
--trace-warnings
--use_strict

https://github.com/MaxCDN/bootstrapcdn/tree/develop-xmr-update-mocha


Isn't this supposed to still work? Going back to v5.2.0 it works as expected without any errors.

Thanks!

@XhmikosR XhmikosR changed the title bad option with 6.x bad option with mocha v6.x Mar 2, 2019
@juergba
Copy link
Member

juergba commented Mar 2, 2019

maybe related to #3788.
Could you please patch "lib/cli/node-flags.js" as per PR3788? It's just one line.
Does it work?

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Mar 2, 2019

Yup, it does fix it. I'm gonna close this and follow #3788 and I'll wait for a new release, thanks!

@XhmikosR XhmikosR closed this as completed Mar 2, 2019
@juergba juergba added type: bug a defect, confirmed by a maintainer and removed unconfirmed-bug labels Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug a defect, confirmed by a maintainer
Projects
None yet
Development

No branches or pull requests

2 participants