Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade docdash version - issue #3663 #3738

Merged
merged 1 commit into from Feb 21, 2019
Merged

Upgrade docdash version - issue #3663 #3738

merged 1 commit into from Feb 21, 2019

Conversation

tendonstrength
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions.

Description of the Change

Upgrading the docdash library to ^2.0.0 per issue #3663

Alternate Designs

N/A

Why should this be in core?

This is need to take advantage of functionality of newer docdash versions

Benefits

Newer features in new docdash versions

Possible Drawbacks

Possible dependency or document formatting issues. I spot checked generated docs and they seemed normal to me.

Applicable issues

Issue #3663

@jsf-clabot
Copy link

jsf-clabot commented Feb 16, 2019 •
edited

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 91.757% when pulling e659e52 on tendonstrength:issue/3663 into 56dc28e on mochajs:master.

@outsideris
Copy link
Member

@tendonstrength Please sign CLA.

outsideris
outsideris approved these changes Feb 17, 2019
View reviewed changes
Copy link
Member

@outsideris outsideris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and docs is fine. except CLA.

@tendonstrength
Copy link
Contributor Author

@outsideris I thought I had signed it and when I go to the CLA site it says I have signed. Weird that the check is not working:

screen shot 2019-02-17 at 9 18 39 am

Is there something I'm missing?

@outsideris
Copy link
Member

@tendonstrength It's weird. The CLA bot may have some problem temporarily.

@tendonstrength
Copy link
Contributor Author

@outsideris I'm going to try closing and re-opening the PR to see if it gives it a kick in the pants.

@tendonstrength tendonstrength mentioned this pull request Feb 17, 2019
Closed
@tendonstrength
Copy link
Contributor Author

I opened an issue against the CLA assistant project. Not sure if they can help but we'll see what they say: cla-assistant/cla-assistant#415

@tendonstrength
Copy link
Contributor Author

@outsideris I fixed the CLA issue. Turns out the commit had my work email address which didn't match my GitHub address. Please let me know if there's anything else, and thanks for taking a look at this.

boneskull
boneskull approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mochajs/core please don't merge until after v6.0.0 is out. @craigtaub is trying to get that release cut very soon.

boneskull
boneskull approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mochajs/core please don't merge until after v6.0.0 is out. @craigtaub is trying to get that release cut very soon.

@boneskull boneskull added area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Feb 18, 2019
@boneskull boneskull added this to the next milestone Feb 21, 2019
@boneskull
Copy link
Member

I'll go ahead and resolve the conflicts and merge here.

@boneskull
Copy link
Member

lgtm, thanks

@boneskull boneskull merged commit b836d73 into mochajs:master Feb 21, 2019
@outsideris outsideris mentioned this pull request Feb 22, 2019
Closed
This was referenced Oct 26, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Nov 25, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsideris outsideris outsideris approved these changes

@boneskull boneskull boneskull approved these changes

Assignees
No one assigned
Labels
area: documentation anything involving docs or mochajs.org semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v6.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tendonstrength @jsf-clabot @coveralls @outsideris @boneskull