Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/mocha: don't spawn child process unnecessarily #3690

Closed
boneskull opened this issue Jan 24, 2019 · 2 comments
Closed

bin/mocha: don't spawn child process unnecessarily #3690

boneskull opened this issue Jan 24, 2019 · 2 comments
Labels
area: node.js command-line-or-Node.js-specific type: cleanup a refactor

Comments

@boneskull
Copy link
Member

boneskull commented Jan 24, 2019

This may or may not be a good idea:

If the user has not passed Node.js-specific or V8-specific arguments, import main from lib/cli/cli.js and execute it.

If the user has passed Node.js-specific or V8-specific arguments, use current behavior.

Advantages:

  • faster startup time

Disadvantages:

  • increased potential for inconsistent behavior
  • would require us to be much more careful about which executable we're using in integration tests
  • would possibly require the same integration tests execute against both executables

This isn't related to process replacement, but that's something else to consider if the hacks aren't too bad.

@boneskull boneskull added type: cleanup a refactor area: node.js command-line-or-Node.js-specific labels Jan 24, 2019
@stale
Copy link

stale bot commented May 24, 2019

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!

@stale stale bot added the stale this has been inactive for a while... label May 24, 2019
@juergba juergba removed the stale this has been inactive for a while... label Jun 3, 2019
@juergba
Copy link
Member

juergba commented Jun 10, 2019

closed, see #3827

@juergba juergba closed this as completed Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific type: cleanup a refactor
Projects
None yet
Development

No branches or pull requests

2 participants