Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mocha@6 #217

Closed
alexkvak opened this issue Feb 19, 2019 · 8 comments
Closed

Support mocha@6 #217

alexkvak opened this issue Feb 19, 2019 · 8 comments

Comments

@alexkvak
Copy link

Have you plans to support mocha v6?

@1999
Copy link
Collaborator

1999 commented Feb 19, 2019

There shouldn't be any problems with that. Maybe you can consider sending a PR for this?
Please don't forget that mocha-parallel-tests is being tested with all mocha versions: https://github.com/mocha-parallel/mocha-parallel-tests/blob/master/package.json#L54

@alexkvak
Copy link
Author

But there are at least two problems:

It is possible to support old version (<6) after these changes?

@1999
Copy link
Collaborator

1999 commented Feb 20, 2019

Let's start with the PR :) IIRC mocha-parallel-tests doesn't rely on these APIs so I think it should be fine.

@alexkvak
Copy link
Author

alexkvak commented Feb 20, 2019

ok, I've created #218

IIRC mocha-parallel-tests doesn't rely on these APIs so I think it should be fine.

of course it relies. During test run I become a lot of errors such TypeError: Cannot read property 'passes' of undefined at Spec.Base.epilogue and DeprecationWarning: getOptions() is DEPRECATED and will be removed from a future version of Mocha. Use loadOptions() instead Unhandled asynchronous exception

@1999
Copy link
Collaborator

1999 commented Feb 21, 2019

That's still good to know. Can we fix these issues first?

DeprecationWarning: getOptions() is DEPRECATED and will be removed from a future version of Mocha. Use loadOptions() instead

As for this error:

TypeError: Cannot read property 'passes' of undefined at Spec.Base.epilogue

Seems like mocha changed the way passes/fails are stored inside the runner or maybe runner is no more a thing. Would you like to investigate this or I can take a look at it in about a week or so?

@1999
Copy link
Collaborator

1999 commented Apr 19, 2019

We're almost there. Mocha@6 support is in the master branch.
I'll finish a couple of clean up tasks and publish a new version of mocha-parallel-tests tomorrow.

@alexkvak
Copy link
Author

Awesome news!

@1999
Copy link
Collaborator

1999 commented Apr 19, 2019

Okies, mocha-parallel-tests@2.1.0 has just been published. Enjoy!

@1999 1999 closed this as completed Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants