[20.10 backport] distribution: Error when pulling OCI artifacts #44413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently an attempt to pull a reference which resolves to an OCI artifact (Helm chart for example), results in a bit unrelated error message `invalid rootfs in image configuration`. This provides a more meaningful error in case a user attempts to download a media type which isn't image related. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com> (cherry picked from commit 407e3a4) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/distribution
status/2-code-review
kind/enhancement
vvoland
approved these changes
Nov 7, 2022
|
Thx! let me bring this one in |
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 13, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <christian@paral.in>
paralin
added a commit
to skiffos/buildroot
that referenced
this pull request
Jan 13, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <christian@paral.in>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 14, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <christian@paral.in> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 15, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <christian@paral.in> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit de51efc) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
arnout
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Jan 15, 2023
Bug fixes and enhancements - Improve error message when attempting to pull an unsupported image format or OCI artifact (moby/moby#44413, moby/moby#44569) - Fix an issue where the host's ephemeral port-range was ignored when selecting random ports for containers (moby/moby#44476). - Fix ssh: parse error in message type 27 errors during docker build on hosts using OpenSSH 8.9 or above (moby/moby#3862). - seccomp: block socket calls to AF_VSOCK in default profile (moby/moby#44564). https://github.com/moby/moby/releases/tag/v20.10.22 Signed-off-by: Christian Stewart <christian@paral.in> Signed-off-by: Peter Korsgaard <peter@korsgaard.com> (cherry picked from commit de51efc) Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently an attempt to pull a reference which resolves to an OCI artifact (Helm chart for example), results in a bit unrelated error message
invalid rootfs in image configuration.This provides a more meaningful error in case a user attempts to download a media type which isn't image related.
(cherry picked from commit 407e3a4)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)