Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.10 backport] registry: allow "allow-nondistributable-artifacts" for Docker Hub #44313

Merged
merged 1 commit into from Oct 19, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented Oct 17, 2022

Cherry-pick of #44305

Previously, Docker Hub was excluded when configuring "allow-nondistributable-artifacts". With the updated policy announced by Microsoft, we can remove this restriction; https://techcommunity.microsoft.com/t5/containers/announcing-windows-container-base-image-redistribution-rights/ba-p/3645201

There are plans to deprecated support for foreign layers altogether in the OCI, and we should consider to make this option the default, but as that requires deprecating the option (and possibly keeping an "opt-out" option), we can look at that separately.

(cherry picked from commit 30e5333)

Previously, Docker Hub was excluded when configuring "allow-nondistributable-artifacts".
With the updated policy announced by Microsoft, we can remove this restriction;
https://techcommunity.microsoft.com/t5/containers/announcing-windows-container-base-image-redistribution-rights/ba-p/3645201

There are plans to deprecated support for foreign layers altogether in the OCI,
and we should consider to make this option the default, but as that requires
deprecating the option (and possibly keeping an "opt-out" option), we can look
at that separately.

(cherry picked from commit 30e5333)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
@thaJeztah thaJeztah marked this pull request as draft October 17, 2022 22:19
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

moved it to draft as some other changes have to go in first.

Could you open a backport for 22.06 as well?

@thaJeztah
Copy link
Member

ah! Found the 22.06 one; thanks!

@tianon
Copy link
Member Author

tianon commented Oct 19, 2022

This one is OK now? 😇

@thaJeztah
Copy link
Member

I think it is 👍

@thaJeztah thaJeztah merged commit 2b7f97a into moby:20.10 Oct 19, 2022
@tianon tianon deleted the 20.10-distributable branch October 19, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants