[20.10 backport] Fix file capabilities dropping in Dockerfile #43876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doCopyXattrs() never reached due to copyXattrs boolean being false, as a result file capabilities not being copied. moved copyXattr() out of doCopyXattrs() Signed-off-by: Illo Abdulrahim <abdulrahim.illo@nokia.com> Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 31f654a) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
area/storage
status/2-code-review
impact/changelog
kind/bugfix
|
(Opening a backport for 20.10 as well for consideration, per request from @mikebrow ) |
AkihiroSuda
approved these changes
Jul 28, 2022
corhere
approved these changes
Jul 28, 2022
|
Created a tracking ticket to have a closer look at some things we looked at while deciding if this PR was "safe" to backport; #43882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doCopyXattrs() never reached due to copyXattrs boolean being false, as
a result file capabilities not being copied.
moved copyXattr() out of doCopyXattrs()
(cherry picked from commit 31f654a)
- Description for the changelog
Fixed issue of file capabilities dropping when moving to next command in Dockerfile during image building.
- A picture of a cute animal (not mandatory but encouraged)