New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.10] vendor: update github.com/containerd/cgroups and github.com/cilium/ebpf (for fixing empty docker stats
)
#43567
Conversation
Fixes - docker/for-linux#1284 - containerd/containerd#6700 - moby#43387 Update to cgroups v1.0.1 which has the current proto for cgroupsv1 Need to update cilium/ebpf dependency to v0.4.0 Signed-off-by: Wim <wim@42.be>
@@ -135,13 +135,13 @@ google.golang.org/genproto 3f1135a288c9a07e340ae8ba4cc6 | |||
github.com/containerd/containerd 7cfa023d95d37076d5ab035003d4839f4b6ba791 https://github.com/moby/containerd.git # master (v1.5.0-dev) + patch for CVE-2021-41190 and CVE-2022-24769 | |||
github.com/containerd/fifo 0724c46b320cf96bb172a0550c19a4b1fca4dacb | |||
github.com/containerd/continuity efbc4488d8fe1bdc16bde3b2d2990d9b3a899165 | |||
github.com/containerd/cgroups 0b889c03f102012f1d93a97ddd3ef71cd6f4f510 | |||
github.com/containerd/cgroups b9de8a2212026c07cec67baf3323f1fc0121e048 # v1.0.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious why you didn't bring in 1.0.3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess "smaller diff" (but haven't looked how large the diff would be with 1.0.3)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, less dependencies and the only change needed was the protobuf fix in v1.0.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nice catch for this.
docker stats
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Update to cgroups v1.0.1 which has the current proto for cgroupsv1
Need to update cilium/ebpf dependency to v0.4.0