[20.10 backport] Only check if route overlaps routes with scope: LINK #43360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good if this could be included in 20.10.13. |
thaJeztah
changed the title
thaJeztah
added
the
status/failing-ci
thaJeztah
added
status/2-code-review
area/networking
status/needs-vendoring
and removed
status/failing-ci
Signed-off-by: Mikael Svensson <mikael.svensson@nasdaq.com>
Nossnevs
force-pushed
the
backport-21.x-linux-routeoverlaps-link-only-42598
branch
from
8618a54
to
2825bf7
Compare
|
@thaJeztah Do you have any estimate when 20.10.14 is going to be released? |
|
No, I don't have an estimate yet, but will discuss with other maintainers 👍 |
|
@Nossnevs hi! sorry for the wait; as you may have seen, we were working on a 20.10.14 release for a (minor) security issue, which is why this wasn't included in the 20.10.14 release. 20.10.15 will be a "regular" patch release, so we'll be merging back ports into this branch for that release; I don't have a date yet for that patch release, but we'll be collecting patches in the branch and do a release in the near future. I'll ask for other maintainers to give a review, so that we can merge this one 👍 |
tianon
approved these changes
Mar 24, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport this PR #42598 to be able to use Docker with VPN services in current major version of Docker.
closes #41525
partially addresses #33925
According to original PR.
Signed-off-by: Mikael Svensson mikael.svensson@nasdaq.com
- What I did
Backport #42598 to 20.10.x
- How I did it
Used the change from above PR. I did not however find the test setup that main branch had. Did not add the test change because of that.
- How to verify it
I have not been able to verify it in 20.10.x branch
- Description for the changelog
#41525 Only check if route overlaps routes with scope LINK. Fixes problems with some VPN clients.