Do not forward DNS requests to self. #47744
Merged
+84
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robmry
force-pushed
the
47716_no_dns_req_to_self
branch
2 times, most recently
from
57ed10d
to
8450910
Compare
corhere
approved these changes
Apr 23, 2024
If a container is configured with the internal DNS resolver's own address as an external server, try the next ext server rather than recursing (return SERVFAIL if there are no other servers). Signed-off-by: Rob Murray <rob.murray@docker.com>
robmry
force-pushed
the
47716_no_dns_req_to_self
branch
from
8450910
to
8750614
Compare
akerouanton
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Make it safe to supply the internal DNS server's own address as an external DNS server.
Fix #47716
- How I did it
The internal resolver removes its own address from the list of ext-servers it's given, and logs a message.
- How to verify it
New integration test.
- Description for the changelog