[20.10 backport] Update some tests for supplementary group permissions #44120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tests checking for groups to adjust for new policy updated in de7af81, which caused those tests to fail: === FAIL: amd64.integration-cli TestDockerSwarmSuite/TestSwarmServiceWithGroup (1.94s) docker_cli_swarm_test.go:311: assertion failed: uid=0(root) gid=0(root) groups=0(root),10(wheel),29(audio),50(staff),777 (string) != uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777 (string) --- FAIL: TestDockerSwarmSuite/TestSwarmServiceWithGroup (1.94s) === FAIL: amd64.integration-cli TestDockerCLIRunSuite/TestRunGroupAdd (0.41s) docker_cli_run_test.go:1091: expected output uid=0(root) gid=0(root) groups=10(wheel),29(audio),50(staff),777 received uid=0(root) gid=0(root) groups=0(root),10(wheel),29(audio),50(staff),777 --- FAIL: TestDockerCLIRunSuite/TestRunGroupAdd (0.41s) === FAIL: amd64.integration-cli TestDockerCLIRunSuite/TestRunUserByIDZero (0.41s) docker_cli_run_test.go:790: expected daemon user got uid=0(root) gid=0(root) groups=0(root),10(wheel) --- FAIL: TestDockerCLIRunSuite/TestRunUserByIDZero (0.41s) === FAIL: amd64.integration-cli TestDockerCLIRunSuite (195.70s) Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit c7e77db) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
samuelkarp
approved these changes
Sep 8, 2022
tianon
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tests checking for groups to adjust for new policy updated in de7af81, which caused those tests to fail:
(string)
--- FAIL: TestDockerSwarmSuite/TestSwarmServiceWithGroup (1.94s)
(cherry picked from commit c7e77db)