New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.10 backport] Merge fixes to pkg/system to support FreeBSD's mknod #43686
Conversation
Thanks! Overall this looks harmless to backport, so I'm ok with this; could you perhaps amend the commits, and sign-off the commits with your own DCO sign-off as well? i.e.,
|
Because FreeBSD uses 64-bit device nodes (see https://reviews.freebsd.org/rS318736), Linux implementation of `system.Mknod` & `system.Mkdev` is not sufficient. This change adds freebsd-specific implementations for `Mknod` and Mkdev`. Signed-off-by: Artem Khramov <akhramov@pm.me> (cherry picked from commit f3d3994) Signed-off-by: Doug Rabson <dfr@rabson.org>
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 26dafe4) Signed-off-by: Doug Rabson <dfr@rabson.org>
fb81056
to
f55b030
Compare
I've added my own sign-off - I wasn't sure about that part since I'm not really adding much value here :). Thanks for the feedback. |
Thanks! Yes, it's a bit of a "grey" area. I know a previous check we had would fail if the sign-off wasn't the last line in the commit message, and IANAL, so just in case ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@samuelkarp ptal
The test failure looks like this:
which seems unrelated to the changes in this PR |
Ah! I'll kick CI again; have been spamming the machines a bit with rebuild requests, and we don't set authentication on them, so at times we hit the rate limits on those machines |
Looks to be the same overload issue:
|
Looks like you hit the jackpot; now a flaky test 😂 (I kicked it once more) |
Thanks for the quick turnaround! |
backports:
This allows projects that depend on pkg/system's implementation of mknod such as github.com/openshift/imagebuilder and github.com/containers/buildah to build on FreeBSD.