Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry required for manifest config blobs #43267

Closed
shizhMSFT opened this issue Feb 20, 2022 · 3 comments · Fixed by #43291
Closed

Retry required for manifest config blobs #43267

shizhMSFT opened this issue Feb 20, 2022 · 3 comments · Fixed by #43291
Labels
area/distribution kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.

Comments

@shizhMSFT
Copy link

shizhMSFT commented Feb 20, 2022 •
edited

Describe the results you received:
The manifest config blob of docker schema 2 manifest is directly pulled in distribution/pull_v2.go without any retry logic while layer blobs are pulled via DownloadManager with a retry logic (max 5 times).

Describe the results you expected:

The manifest config blob is retried on network failure as layers are retried by the DownloadManager.

Moby version:

v20.10.12
@thaJeztah thaJeztah added area/distribution kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. labels Feb 23, 2022
@thaJeztah
Copy link
Member

Not sure exactly why no retry was implemented for the manifest itself, although I think the main reason for the download-manager was to control the number of parallel layer downloads (which could more easily cause network congestion); handling of manifest vs layers also is quite different there, so I guess it won't be easy to add it to the existing download-managers (so not sure if it would make sense to try to shoe-horn it into that).

A retry could possibly make sense though

pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
f68d432 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
@pete-woods pete-woods mentioned this issue Feb 24, 2022
Merged
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
fbb6e3b 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
@pete-woods
Copy link
Contributor

PR here: #43291

pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
1b4ebd9 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
856e1f5 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
434b65d 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
d3f5dcc 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
4d7a3cc 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
af79458 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
d66bc96 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
e266520 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
26a4002 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 24, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
0a2ac87 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 25, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
dc5c349 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Feb 28, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
085ce92 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Mar 3, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
6d01cbe 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
thaJeztah pushed a commit to pete-woods/moby that referenced this issue Mar 5, 2022
@pete-woods @thaJeztah
distribution: retry downloading schema config on retryable error
9f3b1a9 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>
pete-woods added a commit to pete-woods/moby that referenced this issue Mar 5, 2022
@pete-woods
distribution: retry downloading schema config on retryable error
ce3b6d1 
fixes moby#43267

Signed-off-by: Pete Woods <pete.woods@circleci.com>

# Conflicts:
#	distribution/pull_v2.go
#	distribution/pull_v2_test.go
#	distribution/xfer/transfer.go
@pete-woods pete-woods mentioned this issue Mar 5, 2022
Merged
@pete-woods
Copy link
Contributor

pete-woods commented Mar 5, 2022 •
edited

20.10 backport created here: #43333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/distribution kind/enhancement Enhancements are not bugs or new features but can improve usability or performance.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

distribution: retry downloading schema config on retryable error pete-woods/moby
4 participants
@pete-woods @thaJeztah @shizhMSFT and others