Missing safepath.Join for darwin

[matejvasek]

It appears that safepath.Join() is missing for darwin. There is however a Linux version. Would this Linux version work also for darwin.

[matejvasek]

Could we just rename internal/safepath/join_linux.go to internal/safepath/join_unix.go and put appropriate build tags to the file?

[matejvasek]

cc @vvoland

[matejvasek]

We use docker as a library in some project, I think we do not actually invoke safepath.Join() however absence of definition breaks compilation for us. So even implementation that just panic() is OK for us.

[matejvasek]

@jjbustamante maybe loader.ParseVolume() could work for us?

[matejvasek]

@thaJeztah thanks for reply, maybe loader.ParseVolume() is the way for us.

[thaJeztah]

I only had a quick peek at the code in the CLI, so be sure to have a look around in the code to see if that's the correct implementation to use.

(in all honesty, handling of volumes is in dire need of a bit of a cleanup, as there's multiple (legacy) APIs still in use for backward-compatibility); let me know if you managed to find a solution though!

[vvoland]

It won't work, the issue is that the parser returns MountPoint, which is defined in volumes/mounts/mount.go, which also uses the safepath 🙈

I don't see an easy way to keep the build failure when actually building the daemon for non-supported platforms with how these things are structured right now... So the easiest way to unblock this is adding a _other.go safepath implementation that just returns an error (no need for panic I think).

[jjbustamante]

Hi @thaJeztah , @vvoland for now I worked around our problem on darwin implementing our validation using loader.ParseVolume() and some string hacks, really awful but it unblock us.
If _other.go safepath implementation can be added that will be great! I will keep and eye on this.