gha: avoid range requests with too big offset #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
crazy-max
approved these changes
Feb 11, 2023
AkihiroSuda
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this error in CI
This has been reported before as well but can't find a tracking issue atm. This is the same issue tonistiigi/go-actions-cache#14 debug was added.
I confirmed that it was coming because of the
offset == size. There might be some containerd bug that causes this read and that usually goes unnoticed because it just results in one extra query and not an error. I haven't figured out what condition triggers this but it might have something to do with parallel pulls of the same blob.Signed-off-by: Tonis Tiigi tonistiigi@gmail.com