-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.11] buildinfo: mark as deprecated #3614
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
tonistiigi
reviewed
Feb 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the option to disable buildinfo like discussed in another issue.
jedevc
reviewed
Feb 13, 2023
crazy-max
force-pushed
the
v0.11_deprecate-buildinfo
branch
from
February 13, 2023 12:20
1f0ea3d
to
fb79a1d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
crazy-max
force-pushed
the
v0.11_deprecate-buildinfo
branch
from
February 26, 2023 09:43
fb79a1d
to
c769c38
Compare
tonistiigi
reviewed
Feb 28, 2023
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
v0.11_deprecate-buildinfo
branch
from
February 28, 2023 05:51
c769c38
to
837b4b2
Compare
tonistiigi
approved these changes
Feb 28, 2023
This was referenced Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #3552 (comment)
Build information has been deprecated in
v0.11
in favor of provenance attestations but we have not yet made changes to add a deprecation notice and update the relevant docs.Also adds
BUILDKIT_BUILDINFO
build arg to disable buildinfo.Will update #3582 to just remove buildinfo implementation as nextv0.12
marks this feature as removed.