Work around broken cargo trim -d #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbeck88
approved these changes
Jul 23, 2021
eranrund
approved these changes
Jul 23, 2021
Yeah, the thing is, I don't know where/when we'd use that cache... It's bifurcated by arch and git revision, it feels like it's only going to be used if you re-run the same check on the same revision without changing anything---but I just want merges to master to start passing CI again, TBH :-) |
jcape
pushed a commit
that referenced
this pull request
Aug 17, 2021
* Update embargoed location list (based on master patches). * Bump all crate versions * Update TERMS-OF-USE.md (#869) * Update changelog. * Work around broken cargo trim -d (#860) * When we test that the code builds, actually build (#826) * Dont do cargo check, because it doesn't link anything. * Pull in mac CI fixes from master. Co-authored-by: Adam Mork <the-real-adammork@users.noreply.github.com> Co-authored-by: garbageslam <beck.ct@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PRs to master are still failing, due to a bug / change in
cargo trim(the--directoryargument doesn't appear to function)In this PR
cargo trim initin the top-level and trusted enclave directories directly.